RFR: 8348888: tier1 closed build failure on Windows after JDK-8348348

Jiangli Zhou jiangli at openjdk.org
Tue Jan 28 19:28:57 UTC 2025


Please review this workaround for the compiler error on Windows. This error occurs in closed build with custom make logic that uses zip_util.c. The error indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on Windows for now until the cause is fully understood.


[2025-01-28T16:57:35,721Z] c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(94): error C2054: expected '(' to follow 'DEF_STATIC_JNI_OnLoad'
[2025-01-28T16:57:35,721Z] c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(94): error C2085: 'ZFILE_Open': not in formal parameter list
[2025-01-28T16:57:35,737Z] c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(94): error C2143: syntax error: missing ';' before '{'
[2025-01-28T16:57:35,737Z] c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(776): warning C4013: 'ZFILE_Open' undefined; assuming extern returning int

-------------

Commit messages:
 - Workaround compiler error on windows.

Changes: https://git.openjdk.org/jdk/pull/23340/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23340&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8348888
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/23340.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23340/head:pull/23340

PR: https://git.openjdk.org/jdk/pull/23340


More information about the core-libs-dev mailing list