RFR: 8348880: Replace ConcurrentMap with AtomicReferenceArray for ZoneOffset.QUARTER_CACHE [v9]
Naoto Sato
naoto at openjdk.org
Wed Jan 29 17:11:53 UTC 2025
On Wed, 29 Jan 2025 15:17:21 GMT, Shaojin Wen <swen at openjdk.org> wrote:
>> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace ConcurrentMap to avoid object allocation caused by boxing from int to Integer during access.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> copyright
test/jdk/java/time/test/java/time/TestZoneOffset.java line 88:
> 86: @Test
> 87: public void test_quarter_cache() throws Exception {
> 88: for (int hour = -18; hour < 18; hour++) {
The offset range is inclusive, so you may want to test +18 hour as well, since it is the edge case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23337#discussion_r1934275318
More information about the core-libs-dev
mailing list