RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

Alan Bateman alanb at openjdk.org
Thu Jan 30 08:40:01 UTC 2025


On Sun, 26 Jan 2025 07:30:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>>> Testing is still clean on my side. I would appreciate if folks can run this through their CIs.
>>> 
>>> I am planning to integrate this on Monday, as long as we discover no new issues.
>> 
>> Did the change to `test/jdk/sun/security/provider/FileInputStreamPool/FileInputStreamPoolTest.java` get lost?
>> I'm pretty sure it was updated, but I no longer see that in the changes, and it failed in my automated test run.
>
>> Testing is still clean on my side. I would appreciate if folks can run this through their CIs.
>> 
>> I am planning to integrate this on Monday, as long as we discover no new issues.
> 
> I ran it through our CI and we seem to have a few tests that aren't in the jdk repo but have a dependency on jdk.internal.ref.Cleaner so they will need to be fixed and/or excluded. Would you mind holding off until Tuesday to give time to get that done? Otherwise I didn't see any issues. I see there is a referenced Graal issue as it looks like they have to do an update to align with the changes here.

> How is it going, @AlanBateman? Any progress on closed tests?

Thanks for giving us time to get this sorted out.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22165#issuecomment-2623847692


More information about the core-libs-dev mailing list