RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]
Roger Riggs
rriggs at openjdk.org
Tue Jul 1 01:50:45 UTC 2025
On Mon, 30 Jun 2025 19:38:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Replaces the implementation `readAllCharsAsString().lines().toList()` with reading into a temporary `char` array which is then processed to detect line terminators and copy non-terminating characters into strings which are added to the list.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8358533: Sherman's version + decrease initial buffer size
test/jdk/java/io/Reader/ReadAll.java line 117:
> 115: sb.setLength(0);
> 116: }
> 117:
Does one of these cases result in a *very very long line without a terminator"; something that would trigger the limits of ArraySupport.newLength at or near Integer.MAX_VALUE - 8?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r2176240122
More information about the core-libs-dev
mailing list