RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]
Roger Riggs
rriggs at openjdk.org
Tue Jul 1 19:19:40 UTC 2025
On Tue, 1 Jul 2025 16:34:51 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> I don't know, but I doubt it. I will look into adding something.
>
> With this change
>
> --- a/test/jdk/java/io/Reader/ReadAll.java
> +++ b/test/jdk/java/io/Reader/ReadAll.java
> @@ -115,6 +115,8 @@ public static void setup() throws IOException {
> sb.setLength(0);
> }
>
> + strings.add(" ".repeat(Integer.MAX_VALUE/2));
> +
>
> the limit is reached but it doubles the test run time, at least on an M4 Max.
Yea, seems a waste to run it every time. I don't think we run any tests statistically *some of the time".
Maybe if it was limited to run only in *big* configurations, maybe a separate @run with:
`@requires os.maxMemory >= 6g`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r2178365431
More information about the core-libs-dev
mailing list