RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v2]
David Beaumont
duke at openjdk.org
Tue Jul 1 20:39:43 UTC 2025
On Tue, 1 Jul 2025 18:45:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> test/jdk/jdk/internal/jimage/ImageReaderTest.java line 78:
>>
>>> 76:
>>> 77: @Test
>>> 78: public void testModuleDirectories() throws IOException {
>>
>> I could make these more data driven (i.e. parametrized) if people want.
>
> yes, please, it will make failures easier to identity.
I may not get to this before taking leave, but I will do it.
It doesn't make sense to parameterise all tests, but I'll do the basic ones like this.
Not having it spin up a new jimage for each obviously helps :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2178471074
More information about the core-libs-dev
mailing list