RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]
Daniel Jeliński
djelinski at openjdk.org
Wed Jul 2 07:51:01 UTC 2025
On Fri, 27 Jun 2025 13:21:12 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java with -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too
>> - retry the ResetControlStream test as needed
>> - http3: fix pending connection and reconnection on stream limit reached logic
>> - http3: pending acknowledgement should be registered before actually sending the packet
>> - http3: fix race with ping requests in PacketSpaceManager.java causing intermittent failures in H3ErrorHandlingTest.java
>> - http3: improve exceptions in Http3ServerExchange.java
>> - http3: fix exception handling in CancelRequestTest.java
>> - http3: review feedback - revert HPACK.java
>> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC
>> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215
>
> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line 224:
>
>> 222: // TODO in future, when QuicTLSEngine might become a public exported interface
>> 223: // we should have a method on javax.net.ssl.X509ExtendedKeyManager that
>> 224: // takes QuicTLSEngine.
>
> Suggestion:
>
> // TODO in future, if QuicTLSEngine ever becomes a public exported interface
> // we might have a method on javax.net.ssl.X509ExtendedKeyManager that
> // takes QuicTLSEngine.
Maybe we could stop guessing the future, and use this instead:
Suggestion:
// TODO add a method on javax.net.ssl.X509ExtendedKeyManager that
// takes QuicTLSEngine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2179367158
More information about the core-libs-dev
mailing list