RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v3]

[David Beaumont]

On Tue, 1 Jul 2025 14:29:51 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback changes.
>>   
>>   * Making some simple tests parametrized.
>>   * Revert change to JImageReadTest (it passes either way, so keep it simple).
>
> test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmark.java line 60:
> 
>> 58: @OutputTimeUnit(TimeUnit.MILLISECONDS)
>> 59: @Fork(value = 1, jvmArgs = {"--add-exports", "java.base/jdk.internal.jimage=ALL-UNNAMED"})
>> 60: public class ImageReaderBenchmark {
> 
> This is the benchmark from the other PR, did you mean to include it?

Yes, because the API changed. Once the other PR is merged this will just show the diffs (github is refusing to show just the diffs even though I told it to use the other PR).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2179452274