RFR: 8361253: CommandLineOptionTest library should report observed values on failure
Manuel Hässig
mhaessig at openjdk.org
Fri Jul 4 13:09:43 UTC 2025
On Wed, 2 Jul 2025 11:00:44 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
> When a check in `CommandLineOptionTest` fails, the `AssertionError` message contains the expected value, but not the observed value. To reduce the amount of digging in the logs we have to do when analyzing a failure, this PR adds the observed value to the error messages. So instead of
>
>
> java.lang.AssertionError: Option 'CICompilerCount' is expected to have '12' value
>
>
> a mismatch in the `CICompilerCount` will now print
>
>
> java.lang.AssertionError: Option 'CICompilerCount' is expected to have '12' value, but is 'CICompilerCount = 6'.
>
>
> Testing:
> - [x] Github Actions
> - [x] tier1 through tier3 plus Oracle internal testing
Thank you for your reviews.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26092#issuecomment-3036225388
More information about the core-libs-dev
mailing list