RFR: 8361300: Document exceptions for Unsafe offset methods [v4]
Viktor Klang
vklang at openjdk.org
Mon Jul 7 10:00:55 UTC 2025
On Mon, 7 Jul 2025 09:56:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Test to verify observed internal unsafe behaviors
>
> src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java line 407:
>
>> 405: if (Modifier.isStatic(modifiers))
>> 406: throw new IllegalArgumentException("Must not be a static field");
>> 407:
>
> @viktorklang-ora @DougLea Should we update the Atomic*FieldUpdater to specify the IAE when the factory method is called with a static Field?
@AlanBateman Yeah, I think that makes sense—IIRC it's been that way in practice since forever, but making it clear in documentation seems like the right thing to do.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25945#discussion_r2189557771
More information about the core-libs-dev
mailing list