RFR: 8361300: Document exceptions for Unsafe offset methods [v4]

Chen Liang liach at openjdk.org
Mon Jul 7 12:09:39 UTC 2025


On Mon, 7 Jul 2025 09:54:28 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test to verify observed internal unsafe behaviors
>
> src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java line 405:
> 
>> 403:                 throw new IllegalArgumentException("Must be volatile type");
>> 404: 
>> 405:             if (Modifier.isStatic(modifiers))
> 
> Can we break out the Modifier tests in the three updater classes to a common method?

Should we include that in this patch?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25945#discussion_r2189863484


More information about the core-libs-dev mailing list