RFR: 8361526: Synchronize ClassFile API verifier with hotspot
Chen Liang
liach at openjdk.org
Tue Jul 8 17:03:38 UTC 2025
On Tue, 8 Jul 2025 16:28:45 GMT, ExE Boss <duke at openjdk.org> wrote:
>> The class file API verifier seems to be based off a version of hotspot verifier before Mar 3 2021. We are thus missing a few patches in the hotspot verifier:
>> [JDK-8350029](https://bugs.openjdk.org/browse/JDK-8350029) [JDK-8340110](https://bugs.openjdk.org/browse/JDK-8340110) [JDK-8330606](https://bugs.openjdk.org/browse/JDK-8330606) [JDK-8314295](https://bugs.openjdk.org/browse/JDK-8314295) [JDK-8270398](https://bugs.openjdk.org/browse/JDK-8270398) [JDK-8267118](https://bugs.openjdk.org/browse/JDK-8267118) [JDK-8262368](https://bugs.openjdk.org/browse/JDK-8262368) [JDK-8272096](https://bugs.openjdk.org/browse/JDK-8272096) [JDK-8349923](https://bugs.openjdk.org/browse/JDK-8349923)
>>
>> Synchronization allows the ClassFile API verifier to catch up with upcoming verification changes for Valhalla strict fields as well.
>>
>> Testing: select javac tests and classfile tests, running tier 1-3
>
> src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerifierImpl.java line 143:
>
>> 141: // 8330606 Not applicable here
>> 142: return true;
>> 143: }
>
> It’s good that `ClassFile::verify(…)` will now verify these types.
>
> - https://github.com/openjdk/jdk/pull/19826#pullrequestreview-2382543361
True, I thought you created a bugs.java.com issue but I couldn't find it; anyways now VerifierSelfTest should cover cover these classes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26174#discussion_r2193023020
More information about the core-libs-dev
mailing list