RFR: 8354242: VectorAPI: combine vector not operation with compare [v10]

[erifan]

On Tue, 8 Jul 2025 11:42:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> erifan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - Align indentation
>>  - Merge branch 'master' into JDK-8354242
>>  - Address more comments
>>    
>>    ATT.
>>  - Merge branch 'master' into JDK-8354242
>>  - Support negating unsigned comparison for BoolTest::mask
>>    
>>    Added a static method `negate_mask(mask btm)` into BoolTest class to
>>    negate both signed and unsigned comparison.
>>  - Addressed some review comments
>>  - Merge branch 'master' into JDK-8354242
>>  - Refactor the JTReg tests for compare.xor(maskAll)
>>    
>>    Also made a bit change to support pattern `VectorMask.fromLong()`.
>>  - Merge branch 'master' into JDK-8354242
>>  - Refactor code
>>    
>>    Add a new function XorVNode::Ideal_XorV_VectorMaskCmp to do this
>>    optimization, making the code more modular.
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/04bd77d0...db78dc43
>
> src/hotspot/share/opto/vectornode.cpp line 2241:
> 
>> 2239:       in1->outcnt() != 1 ||
>> 2240:       !(in1->as_VectorMaskCmp())->predicate_can_be_negated() ||
>> 2241:         !VectorNode::is_all_ones_vector(in2)) {
> 
> Suggestion:
> 
>       !in1->as_VectorMaskCmp()->predicate_can_be_negated() ||
>       !VectorNode::is_all_ones_vector(in2)) {
> 
> Remove the indentation again, and the superfluous brackets too ;)

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2194130835