RFR: 8360163: Replace hard-coded checks with AOTRuntimeSetup and AOTSafeClassInitializer [v11]
Ioi Lam
iklam at openjdk.org
Wed Jul 9 16:21:42 UTC 2025
On Wed, 9 Jul 2025 13:25:22 GMT, Chen Liang <liach at openjdk.org> wrote:
>> I have updated this patch to avoid a redundant `runtimeSetup` annotation - we have agreed that the requirement for setup is a side effect of initialization, and such methods in AOTCI classes must be automatically recognized. This latest revision implements that model.
>>
>> I intentionally avoided handling Class and ClassLoader `resetArchivedStates` and `MethodType::assemblySetup` - we talked about a generic `assemblyCleanup` method, but I did not find out where is the best place to call such a method in the assembly phase. We cna handle this in a subsequent patch.
>>
>> In particular, please review the new AOT.md design document - I split it from the AOTCI annotation to prevent jamming; we can put general AOT information there when we have more AOT-specific annotations.
>>
>> ---
>>
>> Old description:
>> Currently, the list of classes that have <clinit> interdependencies and those that need runtimeSetup are maintained in a hardcoded list in CDS. This makes it risky for core library developers as they might introduce new interdependencies and observe CDS to fail. By moving the mechanism of these lists to core library annotations as a first step, we can gradually expose the AOT contracts as program semantics described by internal annotations, and also helps us to explore how we can expose these functionalities to the public later.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into exp/cds-mh-anno
> - Merge branch 'master' of https://github.com/openjdk/jdk into exp/cds-mh-anno
> - Reviews
> - Documentation
> - Don't fail for patching tests
> - Remove design document from code
> - Some more from reviews
> - Reviewed the diff on github
> - Stage
> - Missed comment updates
> - ... and 14 more: https://git.openjdk.org/jdk/compare/a201be85...d2dd466b
Marked as reviewed by iklam (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25922#pullrequestreview-3002212362
More information about the core-libs-dev
mailing list