RFR: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v2]

[Alexey Semenyuk]

On Wed, 9 Jul 2025 00:31:39 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java line 184:
>> 
>>> 182:     }
>>> 183: 
>>> 184:     public String validatedBundleIdentifier() throws ConfigException {
>> 
>> This method is private on purpose. It should not be used outside of the MacApplicationBuilder class. If you need to get the valid bundle identifier, create MacApplication instance and call `MacApplication.bundleIdentifier()` on it.
>
> I need it inside `createMacApplication()` before `MacApplication` instance is created.

If you need a property of a `MacApplication` instance, create it and get the property.
`MacApplicationBuilder.validatedBundleIdentifier()` function is internal and should not be used outside of `MacApplicationBuilder`.

It is OK to call `MacApplicationBuilder.create()` multiple times. See how this is done in [LinuxPackageBuilder.java](https://github.com/openjdk/jdk/blob/f36147b3263662229e9a0ec712b9748711d2d85d/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBuilder.java#L48)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discussion_r2205967869