RFR: 8361640: JFR: RandomAccessFile::readLine emits events for each character [v2]

Erik Gahlin egahlin at openjdk.org
Tue Jul 15 17:48:39 UTC 2025


On Tue, 15 Jul 2025 16:09:38 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove traceImplReadLine
>
> src/java.base/share/classes/java/io/RandomAccessFile.java line 1039:
> 
>> 1037:     }
>> 1038: 
>> 1039:     private String traceImplReadLine() throws IOException {
> 
> I think it would be cleaner to have the FileReadEvent usage in readLine. That would reduce this to readLine + implReadLine, no traceImplReadLine.

Refactored the code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26210#discussion_r2208195842


More information about the core-libs-dev mailing list