RFR: 8358880: Performance of parsing with DecimalFormat can be improved [v6]
Chen Liang
liach at openjdk.org
Tue Jul 15 23:55:41 UTC 2025
On Mon, 16 Jun 2025 21:19:45 GMT, Johannes Graham <duke at openjdk.org> wrote:
>> This PR replaces construction of intermediate strings to be parsed with more direct manipulation of numbers. It also has a more streamlined mechanism of handling `Long.MIN_VALUE` when parsing longs by using `Long.parseUnsignedLong`
>>
>> As a small side-effect it also eliminates the use of a cached StringBuilder in DigitList.
>>
>> Testing:
>> - GHA
>> - Local run of tier 2 and jtreg:jdk/java/text
>> - New benchmark: DecimalFormatParseBench
>
> Johannes Graham has updated the pull request incrementally with one additional commit since the last revision:
>
> add comments
Looks reasonable from a code cleanup point of view.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25644#pullrequestreview-3022646136
More information about the core-libs-dev
mailing list