RFR: 8355652: Parse ClassFileFormatVersion from ClassFileVersion
simon
duke at openjdk.org
Sun Jul 20 23:33:39 UTC 2025
On Sun, 20 Jul 2025 22:19:07 GMT, simon <duke at openjdk.org> wrote:
> 8355652: add new method to return ClassFileFormatVersion from ClassFileVersion.
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
>
>
>
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
>
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jdk.git pull/26406/head:pull/26406` \
> `$ git checkout pull/26406`
>
> Update a local copy of the PR: \
> `$ git checkout pull/26406` \
> `$ git pull https://git.openjdk.org/jdk.git pull/26406/head`
>
> </details>
> <details><summary>Using Skara CLI tools</summary>
>
> Checkout this PR locally: \
> `$ git pr checkout 26406`
>
> View PR using the GUI difftool: \
> `$ git pr show -t 26406`
>
> </details>
> <details><summary>Using diff file</summary>
>
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk/pull/26406.diff">https://git.openjdk.org/jdk/pull/26406.diff</a>
>
> </details>
> <details><summary>Using Webrev</summary>
>
> [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/26406#issuecomment-3094832141)
> </details>
@liach I know that I'm commenting on a weekend but it's to you see tomorrow.
I'm commiting a 1.0 version for this implementation - to get your feedback about
I think we should create some unit tests for this API and classes involved. Where do you think that is the most apprpriate location in the project to do it?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26406#issuecomment-3094860148
More information about the core-libs-dev
mailing list