RFR: 8355652: Parse ClassFileFormatVersion from ClassFileVersion
Mikhail Yankelevich
myankelevich at openjdk.org
Mon Jul 21 09:02:45 UTC 2025
On Sun, 20 Jul 2025 22:19:07 GMT, simon <duke at openjdk.org> wrote:
> 8355652: add new method to return ClassFileFormatVersion from ClassFileVersion.
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
>
>
>
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
>
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jdk.git pull/26406/head:pull/26406` \
> `$ git checkout pull/26406`
>
> Update a local copy of the PR: \
> `$ git checkout pull/26406` \
> `$ git pull https://git.openjdk.org/jdk.git pull/26406/head`
>
> </details>
> <details><summary>Using Skara CLI tools</summary>
>
> Checkout this PR locally: \
> `$ git pr checkout 26406`
>
> View PR using the GUI difftool: \
> `$ git pr show -t 26406`
>
> </details>
> <details><summary>Using diff file</summary>
>
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk/pull/26406.diff">https://git.openjdk.org/jdk/pull/26406.diff</a>
>
> </details>
> <details><summary>Using Webrev</summary>
>
> [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/26406#issuecomment-3094832141)
> </details>
src/java.base/share/classes/jdk/internal/classfile/impl/ClassFileVersionImpl.java line 28:
> 26:
> 27: import java.lang.classfile.ClassFileVersion;
> 28: import java.lang.reflect.ClassFileFormatVersion;
Nitpick: copyright year :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26406#discussion_r2218575571
More information about the core-libs-dev
mailing list