RFR: 8355652: Parse ClassFileFormatVersion from ClassFileVersion [v2]
Chen Liang
liach at openjdk.org
Mon Jul 21 21:29:24 UTC 2025
On Mon, 21 Jul 2025 20:48:12 GMT, simon <duke at openjdk.org> wrote:
>>> Maybe it can be reused in another points?
>>
>> ClassFileFormatVersion and Optional are more user-oriented classes; internal code don't really ever use these two types, so I don't think you need to extract this logic specifically.
>
> I mean about the rule the version - similar to isSupportedClassFileVersion method
I still don't think so. I intentionally proposed the original RFE so we have one place where we can consolidate this handling, and that place should be here instead of some other place.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26406#discussion_r2220377268
More information about the core-libs-dev
mailing list