RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v13]
David Beaumont
duke at openjdk.org
Fri Jul 25 18:32:07 UTC 2025
On Wed, 23 Jul 2025 06:34:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback changes.
>
> src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java line 464:
>
>> 462: String nodeName = "/modules/" + module + "/" + name;
>> 463: ImageReader.Node node = reader.findNode(nodeName);
>> 464: return node != null && node.isResource() ? node : null;
>
> Style wise, can you put ( ) around the expression to avoid having to pause and check precedence.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2231771828
More information about the core-libs-dev
mailing list