RFR: 8356438: Update OutputAnalyzer to optionally print process output as it happens [v2]
Alice Pellegrini
duke at openjdk.org
Mon Jul 28 20:10:05 UTC 2025
On Thu, 5 Jun 2025 09:36:37 GMT, Alice Pellegrini <duke at openjdk.org> wrote:
>> The implemented solution modifies the `OutputBuffer` implementation instead of the `OutputAnalyzer` implementation.
>> This is because the **OutputBuffer implementation which handles processes** (LazyOutputBuffer) starts a thread in its constructor, so we would need to add a strange additional constructor parameter to the `OutputBuffer.of(Process, Charset)` static method, while the printing through to stdout (and stderr) only makes sense for LazyOutputBuffer.
>>
>> I believe changing the config option from `outputanalyzer.verbose` to `output buffer.verbose` would make it cleaner, and avoid referencing the OutputAnalyzer in the OutputBuffer implementation.
>
> Alice Pellegrini has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into 8356438-outputanalyzer-optional-print
> - Update test/lib/jdk/test/lib/process/OutputBuffer.java
>
> Co-authored-by: Chen Liang <liach at openjdk.org>
> - Initial working solution
The need will be addressed in the affected test.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25587#issuecomment-3129311861
More information about the core-libs-dev
mailing list