RFR: 8077587: BigInteger Roots [v52]

[Raffaello Giulietti]

On Tue, 29 Jul 2025 13:55:08 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> Well, that was the easy case!
>> (BTW, the condition shExcess != 0 on L.2025 is always true, as shExcess > Double.MAX_EXPONENT - Double.PRECISION there.)
>> 
>> There should be similar reasoning for the `else` part on L.2020.
>> 
>> And, more importantly so, for the more obscure parts (for a 1st time reader, not for the author ;-) ) starting at L.2034. This is the code that took most of my time.
>
>> starting at L.2034. This is the code that took most of my time.
> 
> @rgiulietti And at what line the obscure parts end?

Ah sorry, it ends at L.2073, with the end of the loop.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24898#discussion_r2239970773