RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v15]

David Beaumont duke at openjdk.org
Tue Jul 29 17:59:02 UTC 2025


On Tue, 29 Jul 2025 17:11:28 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removing direct references to JrtFS.
>
> test/jdk/jdk/internal/jimage/JImageReadTest.java line 350:
> 
>> 348:         try (ImageReader badReader = ImageReader.open(imageFile, otherOrder)) {
>> 349:             Assert.fail("Reader should not be openable with the wrong byte order.");
>> 350:         } catch (IOException expected) {
> 
> In passing, you can use `assertThrows(IOException.class(), () -> ImageReader.open(..))` here if you want.

I don't think I can, can I? That method takes a Runnable, not some sort of Callable that throws E.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2240563330


More information about the core-libs-dev mailing list