RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v15]
David Beaumont
duke at openjdk.org
Wed Jul 30 10:39:22 UTC 2025
On Tue, 29 Jul 2025 17:30:54 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removing direct references to JrtFS.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 686:
>
>> 684: /// to child nodes, while retaining efficiency when child nodes are accessed
>> 685: /// (since any incomplete nodes will be created and placed in the node cache
>> 686: /// when the parent was first returned to the user).
>
> The new class descriptions for Node, Directory and Resource are very useful for future maintainers. Can you convert these to /* */ style as we've ended up with a mix in this update.
As discussed offline, I converted all the markdown comments for non-visible elements to HTML/JavaDoc.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2242217898
More information about the core-libs-dev
mailing list