RFR: 8077587: BigInteger Roots [v61]

fabioromano1 duke at openjdk.org
Thu Jul 31 13:16:01 UTC 2025


On Wed, 30 Jul 2025 10:30:15 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update javadoc
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1921:
> 
>> 1919:      * The contents of {@code this} are <em>not</em> changed. The value of {@code this}
>> 1920:      * is assumed to be non-negative and the root degree {@code n >= 3}.
>> 1921:      * Assumes {@code bitLength() <= Integer.MAX_VALUE}.
> 
> @rgiulietti This assumption could be dropped, if the shift methods of `MutableBigInteger` would accept `long` shift values too.

@rgiulietti Could make sense to enhance `MBI.leftShift(int)` and  `MBI.rightShift(int)` to `MBI.leftShift(long)` and  `MBI.rightShift(long)`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24898#discussion_r2245366998


More information about the core-libs-dev mailing list