RFR: 8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava

[Per Minborg]

On Fri, 30 May 2025 14:01:04 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Comment out assertions added in JDK-8351443 from AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize, preventing some inlining, and reducing performance
> 
>        assert coder == newCoder || newCoder == UTF16 : "bad new coder UTF16 -> LATIN1";
>        assert count <= newCapacity : "count exceeds new capacity";

Using this proposed patch, did we see any improvements in BioJava?

Did we consider adding `@ForceInline` for `ensureCapacityNewCoder()`?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25550#issuecomment-2930400282
PR Comment: https://git.openjdk.org/jdk/pull/25550#issuecomment-2930403548