RFR: 8357862: Java argument file is parsed unexpectedly with trailing comment

[Vicente Romero]

On Mon, 2 Jun 2025 13:48:23 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this fix to correctly parse tokens in an argument file that contains trailing comments without preceding whitespace characters before the '#' comment marker, the number sign.
>> 
>> The specifaction of the `java` Command has in section [java Command-Line Argument Files](https://docs.oracle.com/en/java/javase/12/docs/specs/man/java.html#java-command-line-argument-files):
>> 
>> Use the number sign `#` in the argument file to identify comments.
>> All characters following the `#` are ignored until the end of line.
>> 
>> There is not requirement specified to prepend a comment in a line with at least one argument with one or more preceding whitespace characters.
>
> src/java.base/share/native/libjli/args.c line 276:
> 
>> 274:                     }
>> 275:                     pctx->cptr = nextc + 1;
>> 276:                     return token;
> 
> This code duplicates a large part of the block of the previous case. Perhaps an internal helper method could be extracted?

right I agree that if there is common code we should extract it in a helper method

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25589#discussion_r2121454132