RFR: 8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException

[SendaoYan]

On Mon, 2 Jun 2025 21:48:04 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a regression caused by the fix to JDK-8356985. Although the fix in `CharsetTest` was a clean-up and not the gist of the original issue, the change seem to have caused not finding `SkippedException` at runtime in certain cases. Changing the test to JUnit based so that the offending `SkippedException` can be replaced with JUnit's `Assumptions`. Also renamed the test case itself to reflect what's actually tested in it.

test/jdk/java/io/Console/StdoutEncodingTest.java line 41:

> 39:  *          Console.charset() method. "expect" command in Windows/Cygwin
> 40:  *          does not work as expected. Ignoring tests on Windows.
> 41:  * @requires (os.family == "linux") | (os.family == "mac")

The previous line say `Ignoring tests on Windows.`, so this line maybe set as


@requires os.family != "windows"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25601#discussion_r2122774215