RFR: 8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException [v2]

[Naoto Sato]

On Tue, 3 Jun 2025 06:13:35 GMT, Johannes Döbler <duke at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use of OutputAnalyzer.shouldHaveExitValue() where appropriate
>
> test/jdk/java/io/Console/StdoutEncodingTest.java line 72:
> 
>> 70:         if (eval != 0) {
>> 71:             throw new RuntimeException("Test failed. Exit value from 'expect' command: " + eval);
>> 72:         }
> 
> suggestion: `assertEquals(0, eval, "exit value");`

Thanks. I replaced it (and other locations applicable) with `OutputAnalyzer.shouldHaveExitValue()`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25601#discussion_r2124450355