RFR: 8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException [v2]
Joe Wang
joehw at openjdk.org
Tue Jun 3 17:28:54 UTC 2025
On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in `CharsetTest` was a clean-up and not the gist of the original issue, the change seem to have caused not finding `SkippedException` at runtime in certain cases. Changing the test to JUnit based so that the offending `SkippedException` can be replaced with JUnit's `Assumptions`. Also renamed the test case itself to reflect what's actually tested in it.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>
> Use of OutputAnalyzer.shouldHaveExitValue() where appropriate
Marked as reviewed by joehw (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25601#pullrequestreview-2893434471
More information about the core-libs-dev
mailing list