RFR: 8358558: (zipfs) Reorder the listing of accessMode property in the ZIP file system's documentation
Daniel Fuchs
dfuchs at openjdk.org
Wed Jun 4 13:19:31 UTC 2025
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this trivial doc-only change to the `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to the top of the table instead of being at the bottom. With this change, the text about throwing `IllegalArgumentException` when `create=true` and `accessMode=readOnly` has been moved to the `create` property's description.
>
> No functional or specification changes are involved. I verified that the generated documentation looks fine too.
src/jdk.zipfs/share/classes/module-info.java line 195:
> 193: * If the value is {@code true}, the ZIP file system provider creates a
> 194: * new ZIP or JAR file if it does not exist. Specifying the {@code create}
> 195: * property as {@code true} with the {@code accessMode} as {@code readOnly}
should we change that to `with <em>read-only</em> {@code accessMode}` or to `with the {@code accessMode} as {@code "readOnly"}`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25634#discussion_r2126150769
More information about the core-libs-dev
mailing list