RFR: 8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava

Martin Doerr mdoerr at openjdk.org
Wed Jun 4 16:25:00 UTC 2025


On Fri, 30 May 2025 14:01:04 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Comment out assertions added in JDK-8351443 from AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize, preventing some inlining, and reducing performance
> 
>        assert coder == newCoder || newCoder == UTF16 : "bad new coder UTF16 -> LATIN1";
>        assert count <= newCapacity : "count exceeds new capacity";

LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25550#pullrequestreview-2897377032


More information about the core-libs-dev mailing list