RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]
Artur Barashev
abarashev at openjdk.org
Tue Jun 10 22:12:46 UTC 2025
On Fri, 6 Jun 2025 12:00:37 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>>
>> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
>> It adds a non-exposed / non-exported internal implementation of the QUIC protocol based on DatagramChannel and the SunJSSE SSLContext provider.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 499 commits:
>
> - merge latest changes from master branch
> - http3: improve H3ConnectionPoolTest.java
> - Fix snippet
> - Improve key destruction
> - merge latest changes from master branch
> - http3: fix bug introduced by Http3ConnectionPool and improved debug logs
> - http3: refactor HTTP/3 connection pool management in a separate class
> - Ignore DestroyFailedExceptions
> - Remove outdated TODO
> - Remove outdated TODO
> - ... and 489 more: https://git.openjdk.org/jdk/compare/65fda5c0...a5a0c7f8
src/java.base/share/classes/sun/security/ssl/X509Authentication.java line 229:
> 227: // any algorithm constraints when choosing the client alias and
> 228: // just call the functionally limited
> 229: // javax.net.ssl.X509KeyManager.chooseClientAlias(...)
This comment should be updated as we do take into account algorithm constraints. I would remove `TODO` word as well, maybe replace it with `NOTE`
src/java.base/share/classes/sun/security/ssl/X509Authentication.java line 328:
> 326: // any algorithm constraints when choosing the server alias
> 327: // and just call the functionally limited
> 328: // javax.net.ssl.X509KeyManager.chooseServerAlias(...)
Same as above, update the comment
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2138847212
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2138847768
More information about the core-libs-dev
mailing list