RFR: 8357862: Java argument file is parsed unexpectedly with trailing comment [v2]

Christian Stein cstein at openjdk.org
Wed Jun 11 08:35:29 UTC 2025


On Tue, 10 Jun 2025 08:15:58 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Or the handling of `#` can be merged with the previous case ... somehow.
>
> Extracting a method wouldn't really simplify the code, as many local variables are in play.
> 
> Merging the cases also ends up in more if-else constructs in the case block that counter-act readability.
> 
> So, perhaps, the duplication is goog-enough here?

Created an internal shared function in https://github.com/openjdk/jdk/pull/25589/commits/bea8cc7905541e339ed30d0618e70ab6db7b6da6

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25589#discussion_r2139538469


More information about the core-libs-dev mailing list