RFR: 8359182: Use @requires instead of SkippedException for MaxPath.java
Brian Burkhalter
bpb at openjdk.org
Wed Jun 11 21:34:27 UTC 2025
On Wed, 11 Jun 2025 07:15:43 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> I think use `@requires (os.family == "windows")` is more elegant than thow jtreg.SkippedException in test java/io/File/MaxPath.java.
>
> On linux before this PR, run this test jtreg report:
>
>
> TEST: java/io/File/MaxPath.java
> TEST RESULT: Passed. Skipped: jtreg.SkippedException: This test is run only on Windows
>
>
> On linux after this PR, run this test jtreg report:
>
>
> Test results: no tests selected
>
>
> Change has been verified locally both on linux and windows, test-fix only, no risk.
Looks fine. I also verified on Linux and Windows.
-------------
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25742#pullrequestreview-2918800295
More information about the core-libs-dev
mailing list