RFR: 8359182: Use @requires instead of SkippedException for MaxPath.java
SendaoYan
syan at openjdk.org
Thu Jun 12 07:54:34 UTC 2025
On Wed, 11 Jun 2025 22:37:53 GMT, Brent Christian <bchristi at openjdk.org> wrote:
>> Hi all,
>>
>> I think use `@requires (os.family == "windows")` is more elegant than thow jtreg.SkippedException in test java/io/File/MaxPath.java.
>>
>> On linux before this PR, run this test jtreg report:
>>
>>
>> TEST: java/io/File/MaxPath.java
>> TEST RESULT: Passed. Skipped: jtreg.SkippedException: This test is run only on Windows
>>
>>
>> On linux after this PR, run this test jtreg report:
>>
>>
>> Test results: no tests selected
>>
>>
>> Change has been verified locally both on linux and windows, test-fix only, no risk.
>
> Marked as reviewed by bchristi (Reviewer).
Thanks @bchristi-git @bplb for the verify and reviews.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25742#issuecomment-2965520823
More information about the core-libs-dev
mailing list