RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v2]

[Jaikiran Pai]

On Wed, 11 Jun 2025 22:40:43 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which finishes Applet removal for the test: jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>> 
>> `testclasses.jar` is updated such that the two classes no longer extend Applet.
>> 
>> 
>> $ javap fo\ o.class 
>> public class fo o {
>> }
>> $ javap æ$'\302\211'$'\302\213'å$'\302\206'$'\302\214'.class 
>> public class 手册 {
>> }
>> 
>> 
>> The bug description of [JDK-8358729](https://bugs.openjdk.org/browse/JDK-8358729) contains the original `javap` output for those classes.
>> 
>> Additionally, the security APIs that were marked for removal are also removed from this test as well.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Jai's review - dynamically create jar file

Thank you Justin for these changes. Overall I believe these are the correct changes to do. I have some review suggestions which I've added inline.

I went back and looked at the JDK-5017871 issue through which the `fo o.class` was being tested and from what I see in there, the current test changes continue to test that issue. I think there might be better ways to test that original use case and this test could be simplified a lot, but it's certainly not for this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25703#issuecomment-2967307795