RFR: 8352565: Add native method implementation of Reference.get() [v11]

Kim Barrett kbarrett at openjdk.org
Mon Jun 16 07:09:39 UTC 2025


> Please review this change which adds a native method providing the
> implementation of Reference::get.  Referece::get is an intrinsic candidate, so
> this native method implementation is only used when the intrinsic is not.
> 
> Currently there is intrinsic support by the interpreter, C1, C2, and graal,
> which are always used.  With this change we can later remove all the
> per-platform interpreter intrinsic implementations, and might also remove the
> C1 intrinsic implementation.
> 
> Testing:
> (1) mach5 tier1-6 normal (so using all the existing intrinsics).
> (2) mach5 tier1-6 with interpreter and C1 Reference::get intrinsics disabled.

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:

 - Merge branch 'master' into native-reference-get
 - add pseudo-native entry for Reference.get0
 - tidy CallGenerator lookup in Compile ctor
 - fix comment alignment
 - Merge branch 'master' into native-reference-get
 - make private native Reference.get0 the intrinsic
 - Merge branch 'master' into native-reference-get
 - Merge branch 'master' into native-reference-get
 - use new waitForRefProc, some tidying
 - Merge branch 'master' into native-reference-get
 - ... and 7 more: https://git.openjdk.org/jdk/compare/594b4b31...877e64ca

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24315/files
  - new: https://git.openjdk.org/jdk/pull/24315/files/46ba079f..877e64ca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24315&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24315&range=09-10

  Stats: 39280 lines in 872 files changed: 30089 ins; 5915 del; 3276 mod
  Patch: https://git.openjdk.org/jdk/pull/24315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24315/head:pull/24315

PR: https://git.openjdk.org/jdk/pull/24315


More information about the core-libs-dev mailing list