RFR: 8358533: Improve performance of java.io.Reader.readAllLines
Shaojin Wen
swen at openjdk.org
Wed Jun 18 02:30:32 UTC 2025
On Wed, 18 Jun 2025 00:04:37 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
> Replaces the implementation `readAllCharsAsString().lines().toList()` with reading into a temporary `char` array which is then processed to detect line terminators and copy non-terminating characters into strings which are added to the list.
src/java.base/share/classes/java/io/Reader.java line 505:
> 503: }
> 504:
> 505: eol = false;
Suggestion:
}
Same as above, the local variable eol is not used after being assigned and can be removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r2153510269
More information about the core-libs-dev
mailing list