RFR: 8359123: Misleading examples in jmod man page [v4]
Alan Bateman
alanb at openjdk.org
Wed Jun 18 07:05:44 UTC 2025
On Tue, 17 Jun 2025 17:08:17 GMT, Ana Maria Mihalceanu <duke at openjdk.org> wrote:
>> Please review my PR. This PR includes the following:
>>
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>
> Update commands and description according to review.
src/jdk.jlink/share/man/jmod.md line 186:
> 184: the format `<os>-<arch>`, where `<os>` is the operating system
> 185: and `<arch>` is the hardware architecture. Example values include
> 186: `linux-x64`, `windows-x64`, and `macos-aarch64`.
The values for x64 are actually linux-amd64 and windows-amd64.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25772#discussion_r2153806868
More information about the core-libs-dev
mailing list