RFR: 8360122: Fix java.sql\Connection.java indentation
simon
duke at openjdk.org
Mon Jun 23 15:04:28 UTC 2025
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> The indentation fixes look ok. The reformatting of declarations seem unnecessary and create lines that are longer than desirable to be able to do side-by-side compares (100 char max). Generally, avoid just asking the IDE to re-format the source, it leads to unnecessary changes.
I'm going to undo the formatting changes where lines exceed 100 characters. Actually, I didn’t ask the IDE to reformat; I only suggested this formatting to improve readability. However, it can make comparisons in the diff view more difficult.
@RogerRiggs Thanks for the review! 😃
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25925#issuecomment-2996839307
More information about the core-libs-dev
mailing list