RFR: 8354242: VectorAPI: combine vector not operation with compare [v8]
erifan
duke at openjdk.org
Wed Jun 25 10:16:40 UTC 2025
On Wed, 11 Jun 2025 09:07:12 GMT, erifan <duke at openjdk.org> wrote:
>> Oh. Ok. Well at least add a `RuntimeException` to an `else` branch then, I would suggest :)
>
> Make sense!
Done
>>> > You are checking IRNode.XOR_VL, "= 0". But you are comparing floats. Does that make sense?
>>
>>> The bottom types of float and double vector masks are casted to int and long. Seems this is by design? So this is correct.
>>
>> This is a `float` test. What is the bottom type for the mask here?
>
> Oh, this is a stupid copy-paste mistake. Good catch, thanks! I'll double check them all.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2166347264
PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2166349306
More information about the core-libs-dev
mailing list