RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) [v2]
Jaikiran Pai
jpai at openjdk.org
Thu Jun 26 13:42:34 UTC 2025
On Wed, 25 Jun 2025 10:20:15 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/JDK-8359830?
>>
>> macOS operating system's newer version 26 (currently in Beta) is reported as a 16 by older versions of XCode. JDK internally uses the `NSProcessInfo` and `NSOperatingSystemVersion` APIs to identify the macOS version and set the `os.version` system property to that value. The current recommended version to build the JDK on macOS is XCode 15.4. The `NSOperatingSystemVersion` API on that version of XCode reports macOS version as 16 instead of 26.
>>
>> The commit in this PR updates the JDK code to handle this mismatch and set the `os.version` appropriately to 26. This fix is similar to what we did with macOS BigSur when the macOS version 10.16 was meant to mean 11 https://bugs.openjdk.org/browse/JDK-8253702.
>>
>> The existing `OsVersionTest` has been updated for some trivial clean up. Existing tests in tier1, tier2 and tier3 continue to pass with this change. If anyone has access to a macOS 26 Beta, I request them to build this change and run `tier1` tests to help verify that there aren't any failures.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - merge latest from master branch
> - reduce line length
> - update test
> - 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)
Thank you all for the reviews and inputs on this one.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25865#issuecomment-3008528639
More information about the core-libs-dev
mailing list