RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v4]
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Jun 27 06:42:41 UTC 2025
On Fri, 27 Jun 2025 04:59:58 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> Create a jar directly from the memory instead of real file, this should reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we simply trying to reduce time needed.
>> The jar file created is verified manually running jtreg with retain=all.
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>
> Adapt review feedbacks
test/jdk/tools/jlink/JLink20000Packages.java line 62:
> 60: * jdk.compiler
> 61: * @build tests.*
> 62: * @run main/othervm -Xmx1g -Xlog:init=debug -XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal JLink20000Packages
I suspect the `-Xmx1g` was added to make `javac` happy compiling 20 000 classes. If that's the case, we could remove this.
I ran with a max heap of 100M, and the test ran just fine. I think this test is no longer very demanding of heap.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25981#discussion_r2170917716
More information about the core-libs-dev
mailing list