RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

Joe Wang joehw at openjdk.org
Mon Mar 3 19:24:38 UTC 2025


On Mon, 3 Mar 2025 18:01:48 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove commented section
>
> test/jaxp/javax/xml/jaxp/unittest/validation/ValidationTest.java line 151:
> 
>> 149:      *
>> 150:      * @throws Exception if the test fails, in which case the parser throws
>> 151:      * IndexOutOfBoundsException.
> 
> Do we need this `throws Exception` clause (and the method declaration below)? Since AIOOBE is a `RuntimeException`, this `throws` clause does not seem to be necessary. Simple description of the failure case may suffice.

Thanks Naoto. Improved the javadoc a bit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23847#discussion_r1978060161


More information about the core-libs-dev mailing list