RFR: 8350607: Consolidate MethodHandles::zero into MethodHandles::constant [v2]
Chen Liang
liach at openjdk.org
Tue Mar 4 14:15:01 UTC 2025
On Tue, 4 Mar 2025 13:35:50 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> I reviewed the other use of `intrinsicData`, `tableSwitch`. I believe the intrinsic is actually a regression by growing the bytecode size - we should just select a MH via hash table lookup and invoke that MH, given all MHs in that list have the same type. I have removed the use of intrinsic data here and we can move on to remove it later.
>>
>> I noticed that intrinsics are useful really only as part of named functions. And named functions only reuse arbitrary MHs for the invoker form. Is my understanding here correct?
>
>> we should just select a MH via hash table lookup and invoke that MH
>
> I had something like this in an early prototype of the `tableSwitch` combinator, but it does not work, as it prevents the method handle calls for each case from being inlined.
FYI this is being addressed in #23763
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23706#discussion_r1979539450
More information about the core-libs-dev
mailing list