RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

Eric Caspole ecaspole at openjdk.org
Wed Mar 5 15:21:39 UTC 2025


The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH  which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.

-------------

Commit messages:
 - 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem benchmark fails with -ea

Changes: https://git.openjdk.org/jdk/pull/23917/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23917&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8350460
  Stats: 153 lines in 1 file changed: 0 ins; 153 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/23917.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23917/head:pull/23917

PR: https://git.openjdk.org/jdk/pull/23917


More information about the core-libs-dev mailing list