Integrated: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea
Eric Caspole
ecaspole at openjdk.org
Fri Mar 7 21:32:57 UTC 2025
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole <ecaspole at openjdk.org> wrote:
> The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.
This pull request has now been integrated.
Changeset: 76e0f30b
Author: Eric Caspole <ecaspole at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/76e0f30b15efda86cbb974bbc764ac3fb3f0f054
Stats: 157 lines in 1 file changed: 1 ins; 154 del; 2 mod
8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea
Reviewed-by: liach, darcy
-------------
PR: https://git.openjdk.org/jdk/pull/23917
More information about the core-libs-dev
mailing list