RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

[Magnus Ihse Bursie]

On Fri, 14 Mar 2025 13:38:51 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Alternative approach to #24012
>> 
>> This keeps the current handling of *.pdb vs *.stripped.pdb which allows debugging at the cost of a little hack in jlink. Maybe the code in jlink can be improved, e.g. make it more conditional.
>> 
>> I'm running this through our testing still to see whether it'll resolve all of the test issues and does not introduce regressions.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line 226:
> 
>> 224:                             if (Files.exists(strippedPath)) {
>> 225:                                 path = strippedPath;
>> 226:                             }
> 
> This is super weird to put here. I could imagine introducing a Windows specific plugin or option for jlink to help with this setup but I don't think we should rush into a change to JRTArchive to workaround this.

A jlink plugin sounds like a reasonable approach to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24057#discussion_r1995629113